fix(dracut-util): do not call strcmp if the value argument is NULL (bsc#1219841)
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of `strcmp` is undefined if any of its arguments is NULL, which can lead to a segfault depending on the implementation. So, this check is required to be able to use `getargs` with options where the value is optional, e.g., with `rd.break`. bsc#1219841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(dracut-util): do not call
strcmpif thevalueargument is NULLThe behavior of
strcmpis undefined if any of its arguments is NULL, whichcan lead to a segfault depending on the implementation. So, this check is
required to be able to use
getargswith options where the value is optional,e.g., with
rd.break.