Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport upstream fixes for our kernel-install plugins #300

Conversation

aafeijoo-suse
Copy link
Collaborator

No description provided.

Nowa-Ammerlaan and others added 4 commits November 16, 2023 09:55
This can be simply accomplished with the KERNEL_INSTALL_INITRD_GENERATOR
and KERNEL_INSTALL_UKI_GENERATOR variables. `60-ukify.install` looks for
the initrd in the KERNEL_INSTALL_STAGING_AREA and then takes care of building
the uki.

This change makes it possible to use a configuration like this:
/etc/kernel/install.conf
layout=uki
uki_generator=ukify
initrd_generator=dracut

Without this change this configuration will fail since dracut would also
generate an uki instead of initrd, which will cause a problem in
`60-ukify.install` since it can't find an initrd to use.

Signed-off-by: Andrew Ammerlaan <[email protected]>
(cherry picked from commit 1664563)
When the supplied kernel image is a UKI, there's no point in creating
initramfs as the UKI has it built-in already. This is the situation when
dracut.install is called for a distro shipped UKI.

Note, KERNEL_INSTALL_IMAGE_TYPE == "uki" is different from
KERNEL_INSTALL_LAYOUT == "uki", the later can be used to create UKI upon
installing a standard kernel image.

Signed-off-by: Vitaly Kuznetsov <[email protected]>
(cherry picked from commit b2af8c8)
…ovided

If `kernel-install add` is called specifying one or more INITRD-FILEs, the
caller just wants to use these, so there is no point in generating a new one.

Co-authored-by: Zbigniew Jędrzejewski-Szmek <[email protected]>
The `sort-key` field was added in systemd/systemd#22519
and is used by systemd-boot to sort boot entries. Without it, rescue entries
generated by this plugin are not sorted properly.

This patch mimics systemd/systemd@d23b3bfd
keszybz and others added 2 commits November 17, 2023 10:43
…wise

For backwards compat, if it not set, continue as before. But
if set to something else, skip our kernel-install plugins. This allows
an explicit configuration of the initrd generation mechanism.

(cherry picked from commit 0b4be69)
Copy link
Collaborator

@tblume tblume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aafeijoo-suse aafeijoo-suse merged commit 0fc7219 into openSUSE:SUSE/059 Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants