Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path: End in Separator #44

Merged
merged 1 commit into from
May 17, 2018
Merged

Path: End in Separator #44

merged 1 commit into from
May 17, 2018

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented May 15, 2018

Enforce path attributes end in separator.

This will throw a clean formatting error.

Related to #43

Enforce path attributes end in separator.
@RemiLehe
Copy link
Member

The PR is OK ; however this will typically print:

Error: Attribute meshesPath in some_file.h5 does not satisfy format ('meshes' should be in format '^.*\/$')!"

To most users (not used to regex), this might look strange...

Any easy suggestion to improve this?

@ax3l
Copy link
Member Author

ax3l commented May 15, 2018

Yes! We could generally add a hand-written error message for such places! :) #46

@RemiLehe RemiLehe merged commit 29613df into openPMD:2.0.X May 17, 2018
@ax3l ax3l deleted the topic-pathEndInSep branch May 18, 2018 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants