Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Profile picture edit button from Profile Fragment #1162

Closed
wants to merge 1 commit into from
Closed

Removed Profile picture edit button from Profile Fragment #1162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mifospay/src/main/java/org/mifos/mobilewallet/mifospay/home/ui/ProfileFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ public void showProfile(Client client) {
.width((int) getResources().getDimension(R.dimen.user_profile_image_size))
.height((int) getResources().getDimension(R.dimen.user_profile_image_size))
.endConfig().buildRound(client.getName().substring(0, 1), R.color.colorAccentBlack);
ImageView editableImageHint=getView().findViewById(R.id.iv_editable_image_hint);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before and after = is missing, this will lead to failure in lint checks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kartikeytyagi15 are u still able to added these mention changes in your PR's commit

Copy link
Contributor

@Prashant830 Prashant830 Aug 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kartikeytyagi15, @EGOR-IND I think u guys are not able to solves these changes at this time, So Now I am generated new Pr for this particular issue.

editableImageHint.setVisibility(View.INVISIBLE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, as I expected, but you didn't checked the ./gradlew check requirement. You should do run that command in your android studio terminal, it helps you to check whether your code style is according to the project style but your changes already passed that test on github PR, so no worries, but keep in mind from now that you run "./gradlew check" command before performing commit because many PR's get stuck in checkstyle test and then you have to make a new commit and squash it, so it's better to do it in first attempt. At last just want to say good on I approve it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, thanks for the suggestion and review.

ivUserImage.setImageDrawable(drawable);
tvUserName.setText(client.getName());
}
Expand Down