Adding extra-text to be send with QR code in showQrActivity #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devansh-299 @s-ayush2903 Can you Please Review my PR |
s-ayush2903
reviewed
Jan 9, 2021
| @@ -292,6 +292,7 @@ | |||
| <string name="enter_VPA">Please enter the VPA</string> | |||
| <string name="amount_header">Amount:</string> | |||
| <string name="deleted_successfully">Deleted Successfully</string> | |||
| <string name="scan_mifos_qr">Scan this QR code to pay through Mifos Pay</string> | |||
There was a problem hiding this comment.
Its MifosPay not Mifos Pay
Harshad09
force-pushed
the
Adding-text-showQR
branch
from
d2195db
to
94417d7
Compare
|
@s-ayush2903 Changed Mifos Pay to MifosPay |
|
LGTM |
|
@Harshad09 I think, In your branch have a code conflict . Are u still able to resolved it?? |
|
@Harshad09 I think you are not able to solve this conflict code at this time. So now I am going to create new pr for this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #1131
Screenshots
Description
Added Intent.EXTRA_STRING to add a text that should be sent along with the QR code when we share the code to different apps using the android sharesheet.
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.