feat: Support custom contig sep characters in pairix index #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
|character is used to delimit contig names in pairix index blocks, e.g.chr1|chr1,chr1|chr2, etc.However, many FASTA sequence names contain pipes, which conflicts with this usage. Pairix supports creating an index with a different contig separator using
-w, but this hasn't been supported incooler cload pairix. See #234.This PR lets the user provide a custom separator to
cooler cload pairixvia--block-charif it happens to be known or is discovered by the user (unfortunately, pypairix provides no way to determine this character dynamically) and will error if the separator is incorrect.