schizo/ompi: add back in reading ompi mca file #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we ignore pmix mca params in the file now as that's being treated as a separate piece of software that we use as clients. related to open-mpi/ompi#12857 Signed-off-by: Howard Pritchard <[email protected]>
|
This is incorrect - pull the one from upstream |
|
Sorry - didn't mean to be so short in my comment (running around a bit). This change re-introduces errors that were removed in subsequent commits. For example, you will bring back the MCA param problems Edgar previously reported and that I subsequently fixed. In addition, you cannot ignore the PMIx param files as PRRTE utilizes them. For example, users define interfaces to use for the PMIx client-server connection - and PRRTE as well as the client apps need that info. So you really do need to pull the upstream commit I provided to address this issue. It still leaves several questions unanswered, but at least it won't regress the code base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we ignore pmix mca params in the file now as that's being treated as a separate piece of software that we use as clients.
related to open-mpi/ompi#12857