Clean utils args #596
Clean utils args #596
Conversation
| sizevalue *= 1024ULL*1024ULL*1024ULL*1024ULL; | ||
| else if (!strcasecmp(end, "TiB")) | ||
| sizevalue <<= 40; | ||
| } |
There was a problem hiding this comment.
It seems that the treatment is the same whether the extension is [kMGT]B or [kMGT]iB. Isn't shifting left 10 times and multiplying by 1024 the same ?
There was a problem hiding this comment.
Looks like commit 4d9a984 failed to fix [kMGT]B contrary to what the commit message said :)
|
First 2 commits are OK. 3rd one will require 3 months of careful review and mixes several things. I don't like the 4th commit because it makes git blame a bit harder. I usually reindent only when the modify the code nearby. |
|
I pushed the first two commits and fixed the hwloc-annotate bug with units. |
|
I can split it by files and/or by changes (although the changes that are not just the reordering of the options are usually close to it). No problem for the fourth commit. I think you may have told me in the past, but I had forgotten it. Anyhow, I actually put in a separated commit because I knew it was more likely to be refused. |
clementFoyer
force-pushed
the
clean-utils-args
branch
from
cf1be3f
to
9a07410
Compare
|
I pushed the first commit, I'll try to review the last one later today. |
Reorder the options. Signed-off-by: Clément Foyer <[email protected]>
Signed-off-by: Clément Foyer <[email protected]>
clementFoyer
force-pushed
the
clean-utils-args
branch
from
9a07410
to
f097e34
Compare
Mostly code refactoring.
Unify the definition of options to increase code readability. Reorder the option checks to enforce topology options to be parsed first. Unmix using tabs and spaces (excepted for cases when the line is cut due to the function's arguments). Enforce using NULL character instead of simply
0.