Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-338] New Version of config Adapting Swin Transformer Algorithm #1780

Merged
merged 7 commits into from
Sep 8, 2023

Conversation

timerring
Copy link
Contributor

@timerring timerring commented Aug 31, 2023

Adapting New Version of config Adapting Swin Transformer Algorithm, based on open-mmlab/OpenMMLabCamp#338

Motivation

MMEngine has introduced a novel configuration mechanism, utilizing which we will perform configuration file adaptation.

Modification

Add 3 config python files in mmpretrain/configs/_base_/datasets
Add 12 config python files in mmpretrain/configs/_base_/models
Add 1 config python file in mmpretrain/configs/_base_/schedules
Add 7 config python files in mmpretrain/configs/swin_transformer
Add 12 config python files in mmpretrain/configs/swin_transformer_v2

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2023

CLA assistant check
All committers have signed the CLA.

@timerring
Copy link
Contributor Author

Can you please help me with the code review? thanks a lot. @fangyixiao18

@fangyixiao18
Copy link
Collaborator

please remove the folder _base_/models/swin_transformer and _base_/models/swin_transformer_v2, but only keep one file to set model config like swin_transformer_base.py and swin_transformer_v2_base.py,and the training configs all inherit from this swin_transformer_base.py file

Copy link
Collaborator

@fangyixiao18 fangyixiao18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check all file names, and change all '-' to '_'

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage is 60.00% of modified lines.

❗ Current head 896964b differs from pull request most recent head 7734f07. Consider uploading reports for the commit 7734f07 to get more accurate results

Files Changed Coverage
mmpretrain/models/selfsup/itpn.py ø
mmpretrain/models/heads/mae_head.py 60.00%

📢 Thoughts on this report? Let us know!.

@timerring
Copy link
Contributor Author

please remove the folder _base_/models/swin_transformer and _base_/models/swin_transformer_v2, but only keep one file to set model config like swin_transformer_base.py and swin_transformer_v2_base.py,and the training configs all inherit from this swin_transformer_base.py file

Modifications have been completed as required @fangyixiao18

model = dict(
type=ImageClassifier,
backbone=dict(
init_cfg=dict(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set arch


# model settings
model = dict(
backbone=dict(img_size=192, window_size=[12, 12, 12, 6]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set arch, please check other configs

@timerring
Copy link
Contributor Author

Modifications have been completed as required @fangyixiao18

@mzr1996 mzr1996 merged commit 5c71de6 into open-mmlab:dev Sep 8, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants