[BugFix]: KeyError: 'Adafactor is already registered in optimizer at… #1610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… torch.optim'
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers. By the way, if you're not familiar with how to use pre-commit to fix lint issues or add unit tests, please refer to Contributing to OpenMMLab.
Motivation
For solving bug :
Modification
While optimizers are registered, we force to update the optimizer from transformers library because this was the one used prior to same optimizer was introduced by PyTorch
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
Choice was made to force Adafactor from transformers to be used. Hence changes are backward-compatible.
Use cases (Optional)
NA
Checklist