Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ed25519 OIDs and signature algorithm mappings #2

Open
wants to merge 1 commit into
base: eddsa
Choose a base branch
from
Open

Add Ed25519 OIDs and signature algorithm mappings #2

wants to merge 1 commit into from

Conversation

catbref
Copy link

@catbref catbref commented Apr 13, 2018

This allows easier use of JcaContentSignerBuilder to build X509 certificates like so:

JcaX509v3CertificateBuilder certBuilder = new JcaX509v3CertificateBuilder(issuer, serial, notBefore, notAfter, subject, publicKey);
ContentSigner contentSigner = new JcaContentSignerBuilder("SHA512withEd25519").setProvider(BC).build(privateKey);
X509Certificate cert = new JcaX509CertificateConverter().setProvider(BC).getCertificate(certBuilder.build(contentSigner));

OIDs from https://tools.ietf.org/html/draft-ietf-curdle-pkix-07

@Valodim
Copy link
Member

Valodim commented Apr 13, 2018

Hey there. Are you sure you wanted to create this PR against the OpenKeychain fork of bouncy-castle, and not the upstream repo at https://github.com/bcgit/bc-java? :)

@catbref
Copy link
Author

catbref commented Apr 13, 2018

Hi!
I wasn't sure which git to PR against.
I don't know if it's only of use to you because BC aren't/won't merge your own PR?
There doesn't seem to be any action at BC regarding this and I think if you merge my PR then it updates your PR to BC anyway?
Maybe you have a better idea than me!
Also thanks for doing the major work on this!

@catbref
Copy link
Author

catbref commented Apr 24, 2018

Hello again...

Did you ever submit a PR to bouncy-castle for your EDDSA commits?
I can't seem to find one at their repository.
If not, do you mind I create a PR against their master?
Your username would still be mentioned in the PR if that's a concern?

ShellWen pushed a commit to ShellWen/bouncycastle that referenced this pull request Jun 29, 2022
Remove support for maxXofLen in Kangaroo digest

open-keychain#2
ShellWen pushed a commit to ShellWen/bouncycastle that referenced this pull request Jun 29, 2022
Police Blake3 output limit

Given difficulty in testing, outputAvailable was set to 1 and exception
was observed manually.

open-keychain#2
ShellWen pushed a commit to ShellWen/bouncycastle that referenced this pull request Jun 29, 2022
Police Blake3 output limit

Given difficulty in testing, outputAvailable was set to 1 and exception
was observed manually.

open-keychain#2
ShellWen pushed a commit to ShellWen/bouncycastle that referenced this pull request Jun 29, 2022
Add LEAEngine

Found test more test vectors added those.

open-keychain#2
ShellWen pushed a commit to ShellWen/bouncycastle that referenced this pull request Jun 29, 2022
Add LEAEngine

Found test more test vectors added those.

open-keychain#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants