Send content-type header with body #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this would work, but I'm still not completely sure I'd want this to be so hard to override. I'd much prefer that the client implementations just define the default headers with reqwest when creating the client, so that any request could be overridden for them.... but then currently there is no easy way to provide such overrides anyways... So guess that can always change it later before the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside of lib.rs the body function has a comment above it that says "Creates a JSON body" which I think means that it should also send the correct content type header.
I've looked at how reqwest handles this, and they have a dedicated json function inside of the RequestBuilder which does automatically add the content type header.