UniversalCollection and BasicNFT Contracts
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjartek
suggested changes
Apr 18, 2024
|
|
||
| /// Borrow the view resolver for the specified NFT ID | ||
| access(all) view fun borrowViewResolver(id: UInt64): &{ViewResolver.Resolver}? { | ||
| return (&self.ownedNFTs[id] as &{ViewResolver.Resolver}?)! |
There was a problem hiding this comment.
this should not be ! at the end.
|
What's the status of this? |
|
@turbolent It is on hold right now while we wrap up some technical debt. Also, flowty and find were working on UniversalCollection contracts, so we need to review those soon to give them feedback and see how we might be able to potentially collaborate on them |
|
I looked at this yesterday.
https://github.com/bjartek/simple-flow-nft
There are some issues with composing interfaces that prohibits very terse
code.
I belive Austins stab at this is way more refined.
Regards
Bjarte
Bjarte Stien Karlsen
Lofthusveien 77, 4760 Lillesand
…On Mon, 23 Sep 2024 at 19:39, Joshua Hannan ***@***.***> wrote:
@turbolent <https://github.com/turbolent> It is on hold right now while
we wrap up some technical debt. Also, flowty and find were working on
UniversalCollection contracts, so we need to review those
<https://github.com/onflow/dx-internal/issues/2> soon to give them
feedback and see how we might be able to potentially collaborate on them
—
Reply to this email directly, view it on GitHub
<#208 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACS7NLRBYDA43MANKRVJTZYBG3TAVCNFSM6AAAAABFLSHS2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYHE2DCMRQGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
UniversalCollectioncontract, a contract that allows anyone to use its generic collection as their project's collection without having to define their own. This is only meant to be used by projects who don't do anything different with their collection.This will be merged and deployed after the Cadence 1.0 upgrade is complete