Cadence Account Storage Map Migration #6761
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omain-payloads-and-domain-storage-maps
…ntV2Migration contract
|
@turbolent Thanks for working on this part of the integration! Do we want to create a feature branch and target this PR to the feature branch? |
|
@onflow/flow-cadence-execution is there a way to call |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6761 +/- ##
===========================================
+ Coverage 39.71% 43.14% +3.42%
===========================================
Files 1332 45 -1287
Lines 123050 3201 -119849
===========================================
- Hits 48875 1381 -47494
+ Misses 69986 1713 -68273
+ Partials 4189 107 -4082
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start work on the migration logic for onflow/cadence#3584
AccountV2Migration, which is deployed to the service account during bootstrapping. ItsAdminresource is able to trigger the migration for the next batch of accounts to be migrated, by calling the injectedscheduleAccountV2Migrationfunctionfun scheduleAccountV2Migration(addressStartIndex: UInt64, count: UInt64): Boolto the new contractAccountV2Migrationin the service account. It generates the addresses in the given range, and schedules the migration to the new account storage format V2. It essentially just calls the internal Go functionruntime.Storage.ScheduleV2Migration()provided by Cadence.