-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable test TestProtocolVersionUpgrade
#6752
base: jord/6622-chunk-service-events
Are you sure you want to change the base?
Re-enable test TestProtocolVersionUpgrade
#6752
Conversation
Just came across this details while reviewing: flow-go/state/protocol/protocol_state/kvstore/models.go Lines 123 to 126 in a065619
technically, the operators don't submit the epoch recovery transaction - it is the human governance committee. Would you mind updating the documentation (including the typo in sligtly): // Strictly speaking it should be perfectly fine to use a value viewCount >= model.FinalizationSafetyThreshold.
// By using a slightly higher value (factor of 2), we ensure that each extension spans a sufficiently big time
// window for the human governance committee to submit a valid epoch recovery transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
We implemented
TestProtocolVersionUpgrade
as part of the original work around the Protocol KVStore, but disabled it until the corresponding smart contract change was ready to deploy to Mainnet. That smart contract change is now merged to thecore-contracts
feature branch, onflow/flow-core-contracts#465, to be deployed alongside EFM Recovery.This PR re-enables the test.
require-approvals=1
and extends Chunk Data Model supports service event indices #6744, which implements a solution for verifying service events outside the system chunk.