Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Improvements for SubscribeTransactionStatuses statuses handling #6736

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Guitarheroua
Copy link
Contributor

Closes #6574

Updated the logic for checking transaction results. The system now always checks local storage first, and if no transaction result is found, it attempts to retrieve it from the execution node.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.24%. Comparing base (ed149a7) to head (9ee3d6a).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
engine/access/rpc/backend/backend_transactions.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6736      +/-   ##
==========================================
+ Coverage   41.19%   41.24%   +0.04%     
==========================================
  Files        2052     2054       +2     
  Lines      182215   182364     +149     
==========================================
+ Hits        75069    75211     +142     
- Misses     100852   100857       +5     
- Partials     6294     6296       +2     
Flag Coverage Δ
unittests 41.24% <92.85%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Guitarheroua Guitarheroua self-assigned this Nov 20, 2024
@Guitarheroua Guitarheroua marked this pull request as ready for review November 21, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Improve SendAndSubscribe status handling
2 participants