Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crypto contract #456

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Add Crypto contract #456

merged 6 commits into from
Oct 21, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Oct 17, 2024

Work towards onflow/cadence#3135

Test case is adapted from https://github.com/onflow/flow-go-sdk/blob/7eb6328b774496418310a8487a893c070c9e5367/examples/verify_signature/user_signature/main.go.

The Crypto contract code and the Cadence-based tests were originally located in the Cadence codebase, and are going to be removed from there in onflow/cadence#3619. The contract code and test code was moved as-is.

Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to include some more comments in the contract and tests

contracts/flow.json Outdated Show resolved Hide resolved
@turbolent
Copy link
Member Author

@joshuahannan Yes, it would be great to improve the contracts. Once we have put it on chain it should be much easier

@turbolent turbolent merged commit fc1ea49 into master Oct 21, 2024
2 checks passed
@turbolent turbolent deleted the bastian/crypto branch October 21, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants