Add call to dependency audit contract #430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezpodhostnik
force-pushed
the
janez/dependency-audit
branch
from
43a6787
to
0932685
Compare
6 tasks
janezpodhostnik
changed the title
|
CI is failing because the generated files were not intentionally not generated, so that this PR would not get accidentally merged. I don't think this PR should be merged, since we want this feature to go away with 1.0. If we don't merge this PR that would happen automatically when the contract updates to 1.0 during the migration. |
|
I see what you're saying, that makes sense |
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: onflow/flow-go#5858
This is intended to work together with this FVM PR onflow/flow-go#5908 which is already deployed on testnet, so this can be deployed when it is ready.
This imports the
DependenciesAuditcontract defined here: onflow/contract-updater#33This is only needed pre-1.0 and the
checkDependenciesfunction can (and will) be removed post-1.0. At that point the DependenciesAudit contract also becomes useless.DO NOT MERGE