Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Command-Buffers] Implement new command-list enqueue path #1975

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[Command-Buffers] Implement new command-list enqueue path #1975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66c80c9
Use zeCommandListImmediateAppendCommandListsExp
fabiomestre Aug 12, 2024
ca878c5
Merge branch 'main' into fabio/immediate_append_exp
lslusarczyk Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions scripts/core/LEVEL_ZERO.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,15 @@ Environment Variables
| UR_L0_DISABLE_USM_ALLOCATOR | Controls the use of the USM allocator. | "0": USM allocator is enabled. | "0" |
| | | Any other value: USM allocator is disabled. | |
+---------------------------------------------+--------------------------------------------------------------+--------------------------------------------------------------+------------------+

| UR_L0_CMD_BUFFER_USE_IMMEDIATE_APPEND_PATH | Controls which command-buffer implementation path is used. | "1": the immediate append path will always be enabled as | Unset |
Copy link
Contributor

@pbalcer pbalcer Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which path is tested will depend on the CI runner. We should be more explicit about it by testing twice - with and without the "immediate append path" enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, the CI drivers are all older than 30898 and I would assume that that will be the case for the foreseeable future. So it will always use the old path.

I think that, once this extension is not experimental anymore, if we are still using 2 paths in the code, we could add more testing to CI. But for now, I don't think there is much point in doing so.

Copy link
Contributor

@pbalcer pbalcer Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK our PVC runners have a new enough driver (the newest available rolling is 24.39.31294.21), but fair, we can expand CI later. Please create an issue to track this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created ticket #2373

| | The paths rely on different APIs to enqueue command-buffers. | long as the pre-requisites are met. | |
| | The immediate append path relies on | "0": the immediate append path will always be disabled. | |
| | zeCommandListImmediateAppendCommandListsExp(). | "unset": The default behaviour will be used which enables | |
| | The wait-event path relies on | the immediate append path only for some devices when the | |
| | zeCommandQueueExecuteCommandLists() | pre-requisites are met. | |
+---------------------------------------------+--------------------------------------------------------------+--------------------------------------------------------------+------------------+
Contributors
------------

* Neil Spruit `[email protected] <[email protected]>`_
* Neil Spruit `[email protected] <[email protected]>`_
* Fábio Mestre `[email protected] <[email protected]>`_
Loading
Loading