Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hipSYCL] Add hipSYCL GitHub CI #194

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft

[hipSYCL] Add hipSYCL GitHub CI #194

wants to merge 17 commits into from

Conversation

sbalint98
Copy link
Contributor

Description

This PR will add a github CI to test compilation and the CPU target for the BLAS domain with hipSYCL

Checklist

New features

  • Have you provided motivation for adding a new feature?
    Have you added relevant tests?

@sbalint98 sbalint98 changed the title [hipSYCL] Add hipsycl GitHub ci [hipSYCL] Add hipSYCL GitHub CI Apr 26, 2022
@sbalint98 sbalint98 force-pushed the add-hipsycl-github-ci branch 3 times, most recently from bdc17d0 to 2594ec1 Compare May 15, 2022 10:35
@mmeterel
Copy link
Contributor

@sbalint98 What is the status of this PR? If you don't think you will make progress, can we close the PR and open it again when it is ready?

@sbalint98
Copy link
Contributor Author

Pinging @nilsfriess and @normallytangent as they took this over from me.

@nilsfriess
Copy link
Contributor

I wanted to first finish #226 so that we can also add tests for the CUDA backends to the GitHub CI.
But I can also first finish this PR with the backends that are currently supported by hipSYCL if you prefer.

@mmeterel
Copy link
Contributor

@nilsfriess Either way works. I was just trying to understand if you/your team is still working on this PR or not. Thanks for your contributions!

@nilsfriess
Copy link
Contributor

Just to give a quick update @mmeterel : We had some troubles with the cuBLAS backend (see #245 and #249), this is why this PR did not receive any updates. But @normallytangent is no starting to work on this to add the CI builds for the remaining backends that are supported by hipSYCL.

sbalint98 and others added 17 commits March 17, 2023 13:41
@sbalint98 @nilsfriess
Initial CI for hipSYCL
7f5fe46
@sbalint98 @nilsfriess
only test bionic
111e5fb
@sbalint98 @nilsfriess
use the bionic repo
8dfca22
@sbalint98 @nilsfriess
Use rocm 5.1.1
103ffb6
@sbalint98 @nilsfriess
WIP
dc045a5
@nilsfriess
Update github CI workflow file to test compilation of oneMKL with hip…
e22260d 
…SYCL on Ubuntu 18.04 and 20.04

Squashed commit of the following:

commit 5ee7dd1
Author: Nils Friess <[email protected]>
Date:   Thu Jun 30 11:44:57 2022 +0200

    Also test on Ubuntu 18.04 (requires installing boost from source)

commit 4cfe3aa
Author: Nils Friess <[email protected]>
Date:   Thu Jun 23 22:49:30 2022 +0200

    Renamed workflow file

commit 911b977
Author: Nils Friess <[email protected]>
Date:   Thu Jun 23 22:22:39 2022 +0200

    Run also on pull requests

commit 18670fa
Author: Nils Friess <[email protected]>
Date:   Thu Jun 23 22:08:56 2022 +0200

    Revert "Also test on Ubuntu 22.04 LTS"

    This reverts commit 1912951.
    ROCm currently cannot be installed on 22.04.

commit 1912951
Author: Nils Friess <[email protected]>
Date:   Thu Jun 23 22:02:05 2022 +0200

    Also test on Ubuntu 22.04 LTS

commit 2aca44b
Author: Nils Friess <[email protected]>
Date:   Thu Jun 23 22:01:41 2022 +0200

    Format and remove unused flags etc.

commit c976018
Author: Nils Friess <[email protected]>
Date:   Tue Jun 21 11:13:31 2022 +0200

    Fix typo in CMake command

commit 716a3ff
Author: Nils Friess <[email protected]>
Date:   Tue Jun 21 11:04:53 2022 +0200

    Update apt sources before installing boost

commit 78c0b74
Author: Nils Friess <[email protected]>
Date:   Tue Jun 21 10:51:38 2022 +0200

    Remove commands to install tbb and mkl since they are not necessary

commit c3b1abd
Author: Nils Friess <[email protected]>
Date:   Mon Jun 20 14:25:29 2022 +0200

    Run cmake install as sudo

commit 7f4ddbd
Author: Nils Friess <[email protected]>
Date:   Mon Jun 20 14:15:49 2022 +0200

    Add path to lapack in cmake command

commit 33d23a5
Author: Nils Friess <[email protected]>
Date:   Mon Jun 20 14:12:42 2022 +0200

    Install LAPACK from source

commit f87e040
Author: Nils Friess <[email protected]>
Date:   Mon Jun 20 13:53:46 2022 +0200

    Add command to build oneMKL

commit 159db62
Author: Nils Friess <[email protected]>
Date:   Mon Jun 20 13:53:18 2022 +0200

    Fix typo in cmake flag

commit 4d50f8b
Author: Nils Friess <[email protected]>
Date:   Sun Jun 19 13:58:20 2022 +0200

    Add command to install CBLAS (for simplicity we install libatlas)

commit 3527cd8
Author: Nils Friess <[email protected]>
Date:   Sun Jun 19 13:43:03 2022 +0200

    Add command to install cblas

commit 4a6906c
Author: Nils Friess <[email protected]>
Date:   Sun Jun 19 13:28:53 2022 +0200

    Add path to cmake config of hsa-runtime64 as env variable

commit f6f62a9
Author: Nils Friess <[email protected]>
Date:   Sun Jun 19 13:15:35 2022 +0200

    Add path to amd_comgr cmake config as env variable

commit 6fd04a0
Author: Nils Friess <[email protected]>
Date:   Sun Jun 19 12:52:27 2022 +0200

    Add path to cmake config for AMDDeviceLibs as env variable

commit d9fc104
Author: Nils Friess <[email protected]>
Date:   Sun Jun 19 12:41:25 2022 +0200

    Add path to hip cmake config as environment variable

commit 5125368
Author: Nils Friess <[email protected]>
Date:   Sun Jun 19 12:32:52 2022 +0200

    Install rocblas together with rocm

commit 483bdc6
Author: Nils Friess <[email protected]>
Date:   Sun Jun 19 12:23:05 2022 +0200

    Add rocblas_DIR to cmake command

commit fa58d4b
Author: Nils Friess <[email protected]>
Date:   Sun Jun 19 12:13:32 2022 +0200

    Add rocBLAS CMake config path as environment variable

commit 52065e9
Author: Nils Friess <[email protected]>
Date:   Sun Jun 19 11:00:08 2022 +0200

    Fix hipSYCL build paths

commit bd79ccf
Author: Nils Friess <[email protected]>
Date:   Sun Jun 19 10:45:27 2022 +0200

    Add commands for building oneMKL

commit 4b44a68
Merge: be11ced 6b95323
Author: Nils Friess <[email protected]>
Date:   Wed Jun 8 23:26:20 2022 +0200

    Merge branch 'github-ci-test' of github.com:nilsfriess/oneMKL into github-ci-test

commit be11ced
Author: Nils Friess <[email protected]>
Date:   Wed Jun 8 23:23:11 2022 +0200

    Add hipsycl build (including setup for CUDA and ROCm)

commit 6b95323
Author: Nils Friess <[email protected]>
Date:   Wed Jun 8 23:20:41 2022 +0200

    Remove sudo and add hipsycl build

commit 8378aba
Author: Nils Friess <[email protected]>
Date:   Wed Jun 8 23:03:34 2022 +0200

    Add github workflow test file
@normallytangent @nilsfriess
Include Cuda backend. Tested on Ubuntu 20.04 ctest segfaults at Imatc…
a233732 
…opyBatchStrideTests
@normallytangent @nilsfriess
convert tabs to spaces
3e91bff
@normallytangent @nilsfriess
resolve a typo
29a7305
@normallytangent @nilsfriess
lapack change cmd for install
559b3d7
@normallytangent @nilsfriess
fix indentation
4b6a945
@normallytangent @nilsfriess
change to cmake build for lapack
e272d66
@normallytangent @nilsfriess
fix typo in cuda version
43c023d
@normallytangent @nilsfriess
downgrade cuda version to 11.6
3888d38
@normallytangent @nilsfriess
update hipsycl target
329f613
@normallytangent @nilsfriess
add path to clang
d03712a
@normallytangent @nilsfriess
path to cuda
784babf
@nilsfriess nilsfriess force-pushed the add-hipsycl-github-ci branch 2 times, most recently from 1e19a88 to 784babf Compare March 21, 2023 10:32
@normallytangent normallytangent mentioned this pull request Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbalint98 @mmeterel @nilsfriess @normallytangent