-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defining developer roles, responsibilities, and privileges and leadership process #1940
base: main
Are you sure you want to change the base?
Conversation
…f role responsibilities and priviledges.
I believe RFC pull request doesn't require the all 22 CI per commit checks... Likely, only |
It should be pretty easy to put in a filter for the jobs which run tests to do one of the following:
|
@MikeDvorskiy Please see #1941 for a possible implementation of your request. |
Co-authored-by: Matthew Michel <[email protected]>
Thank you! I'll take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This largely looks good to me, other than a few minor things, and the conceptual question about usage of Milestones.
* Demonstrated in-depth knowledge of the architecture of a specific project | ||
component. | ||
* Commits to being responsible for that specific area. | ||
* Can propose new RFC or participate in review of existing RFCs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bullet about RFCs seem to be here by accident.
| SYCL device policies and SYCL backends | Mikhail Dvorskiy<br>Adam Fidel | @MikeDvorskiy<br>@adamfidel | Intel | | ||
| Tested Standard C++ APIs & Utility Function Object Classes | Sergey Kopienko | @SergeyKopeinko | Intel | | ||
| C++17 standard algorithms | Mikhail Dvorskiy<br>Adam Fidel<br>SergeyKopienko<br>Julian Miller<br>Dmitriy Sobolev | @MikeDvorskiy<br>@adamfidel<br>@SergeyKopienko<br>@julianmi<br>@dmitriy-sobolev | Intel<br>Intel<br>Intel<br>Independent<br>Intel | | ||
| Range-Based Algorithms | Mikhail Dvorskiy | @MikeDvorskiy | Intel | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add Ruslan Arutyunyan as another code owner for range algorithms.
|
||
| Component | Code Owner(s) | Github ID | Affiliation | | ||
| --------------------- | ------------------- | --------- | ----------- | | ||
| C++ standard policies and CPU backends | Dan Hoeflinger | @danhoeflinger | Intel | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add Mikhail Dvorskiy as another code owner for CPU backends.
| **_Privileges_** | **Contributor** | **Code Owner** | **Maintainer** | | ||
| Permission granted | [Write][permissions] | [Write][permissions] | [Maintain][permissions] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments regarding the permissions.
First, the table says contributors have write permissions, but the detailed section for contributors mentions only read permissions.
Second, if contributors have write permissions, does it mean that this is the default permission level for anybody? Or does this assume some "process to become a contributor" that grants additional permissions?
As part of the process of adopting UXL governance this PR introduces the roles developers may fill in the project and the process of moving into roles with increased responsibility and privilege. The work is based on the process defined by oneDNN and what has been proposed for oneTBB.