[Dynamic Selection] Adding profiling to sycl backend #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnuyaWelling2801
changed the title
AnuyaWelling2801
changed the title
vossmjp
reviewed
Oct 22, 2024
| @@ -86,6 +85,9 @@ class sycl_backend | |||
| std::chrono::nanoseconds(time_end - time_start))); | |||
| } | |||
| } | |||
| if constexpr (report_info_v<Selection, execution_info::task_completion_t>){ | |||
| s->report(execution_info::task_completion); | |||
There was a problem hiding this comment.
Why no check for s != nullptr in this if?
| if(!e.get_device().has(sycl::aspect::ext_oneapi_queue_profiling_tag)){ | ||
| if (!e.template has_property<sycl::property::queue::enable_profiling>()){ | ||
| auto prop_list = sycl::property_list{sycl::property::queue::enable_profiling()}; | ||
| auto e_tmp = sycl::queue{e.get_device(), prop_list}; |
There was a problem hiding this comment.
Should other properties also be copied from the original queue and then enable_profling added on top of those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed host task and added sycl profiling to sycl_backend