Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sysman init EnumFreqDomain CTS #72

Merged
merged 13 commits into from
Nov 5, 2024
Merged

Sysman init EnumFreqDomain CTS #72

merged 13 commits into from
Nov 5, 2024

Conversation

shreyaskunder
Copy link
Contributor

No description provided.

@shreyaskunder
seperate binary for init cases
8762870 
Signed-off-by: Kunder, Shreyas <[email protected]>
@shreyaskunder
minor rename
92fb3fa 
Signed-off-by: Kunder, Shreyas <[email protected]>
vishnu-khanth
vishnu-khanth approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@vishnu-khanth vishnu-khanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shubskmr
Copy link
Contributor

@shreyaskunder Lets not merge this until sysman fix you are working on is through.

shubskmr
shubskmr requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@shubskmr shubskmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can you please check if we are covering the reverse flow? If not let's create a JIRA and add them, which could be a separate task.

zeInit() + ZES_ENABLE_SYSMAN=1
zesInit()
call sysman APIs with core/sysman handles.

conformance_tests/sysman/test_sysman_init/src/test_init_sysman_enum_freq_with_core_handle.cpp Outdated Show resolved Hide resolved
conformance_tests/sysman/test_sysman_init/src/test_init_sysman_enum_freq_with_sysman_handle.cpp Outdated Show resolved Hide resolved
conformance_tests/sysman/test_sysman_init/src/test_init_sysman_enum_freq_with_core_handle.cpp Show resolved Hide resolved
@shreyaskunder
test: sysman init tests from core and sysman handle
dfad09f 
Related-To: VLCLJ-2273

Signed-off-by: Shreyas Kunder <[email protected]>
@shreyaskunder
test: sysman init tests from core and sysman handle
274d9a5 
Related-To: VLCLJ-2273

Signed-off-by: Shreyas Kunder <[email protected]>
@shreyaskunder
Copy link
Contributor Author

Also can you please check if we are covering the reverse flow? If not let's create a JIRA and add them, which could be a separate task.

zeInit() + ZES_ENABLE_SYSMAN=1
zesInit()
call sysman APIs with core/sysman handles.

Okay will take as separate task.

@shubskmr
Copy link
Contributor

shubskmr commented Nov 5, 2024

Also can you please check if we are covering the reverse flow? If not let's create a JIRA and add them, which could be a separate task.

zeInit() + ZES_ENABLE_SYSMAN=1
zesInit()
call sysman APIs with core/sysman handles.

Okay will take as separate task.

Please add the JIRA here for better tracking.

shubskmr
shubskmr approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@shubskmr shubskmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AshwinKumarKulkarni AshwinKumarKulkarni merged commit 92223ce into oneapi-src:master Nov 5, 2024
13 checks passed
@shreyaskunder
Copy link
Contributor Author

Also can you please check if we are covering the reverse flow? If not let's create a JIRA and add them, which could be a separate task.

zeInit() + ZES_ENABLE_SYSMAN=1
zesInit()
call sysman APIs with core/sysman handles.

Okay will take as separate task.

Please add the JIRA here for better tracking.

https://jira.devtools.intel.com/browse/VLCLJ-2335 created to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviralni aviralni aviralni left review comments

@harinik124 harinik124 harinik124 approved these changes

@vishnu-khanth vishnu-khanth vishnu-khanth approved these changes

@AshwinKumarKulkarni AshwinKumarKulkarni AshwinKumarKulkarni approved these changes

@shubskmr shubskmr shubskmr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shreyaskunder @shubskmr @AshwinKumarKulkarni @vishnu-khanth @aviralni @harinik124