feature: add physical system memory tests 1/n #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related-To: NEO-11981 Signed-off-by: Wenbin Lu <[email protected]>
rwmcguir
reviewed
Nov 22, 2024
| lzt::query_page_size(context, device, allocationSize, &pageSize); | ||
| allocationSize = lzt::create_page_aligned_size(allocationSize, pageSize); | ||
| lzt::physical_host_memory_allocation(context, allocationSize, | ||
| &reservedPhysicalHostMemory); |
There was a problem hiding this comment.
To validate this is actually working, between allocation and destroy, shouldn't we be attempting to at least touch a single of memory to verify it won't segfault? At least on host host side?
There was a problem hiding this comment.
@rwmcguir Yes, I plan to add more tests in future PRs. This one mostly just modifies the test harness to support both host & device memory, so we don't have huge PRs that are difficult to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-To: NEO-11981