fix: avoid out-of-boundary access by profile_add kernel
#100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejBielski
force-pushed
the
fix-kernel_timestamp_event_tests
branch
from
c6d43cf
to
b7db2a9
Compare
The kernel uses `get_global_id()` to index the `values_out[]` array. The index is therefore related to "global work-group size" (GWS) and belongs to `[0, GWS)`. Adjust the GWS so that the kernel does not reach out-of-boundary while accessing each element of the array. - set the "local work-group size" (LWS) to 1 with `set_group_size()` - adjust the GWS by setting `group_count = elems_nb` when (`GWS = LWS * group_count`)` Fix other tests in the same manner. Signed-off-by: Maciej Bielski <[email protected]>
MaciejBielski
force-pushed
the
fix-kernel_timestamp_event_tests
branch
from
b7db2a9
to
8dd4e8a
Compare
JablonskiMateusz
approved these changes
Nov 7, 2024
nrspruit
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel uses
get_global_id()to index thevalues_out[]array.The index is therefore related to "global work-group size" (GWS) and
belongs to
[0, GWS).Adjust the GWS so that the kernel does not reach out-of-boundary while
accessing each element of the array.
set_group_size()group_count = elems_nbwhen(
GWS = LWS * group_count)`Fix other tests in the same manner.
Signed-off-by: Maciej Bielski [email protected]