-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCLomatic] USM_NONE testing fixes #243
base: SYCLomatic
Are you sure you want to change the base?
[SYCLomatic] USM_NONE testing fixes #243
Conversation
It does not seem like using Am I misunderstanding how this should be used? Perhaps this xml need to be updated with an appropriate rule to exclude USM_NONE? I'm also surprised that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are OK to me, pls make sure CI test pass and all conflicts resolved before merging.
d726813
to
dea1a1d
Compare
Thanks. I've rebased and resolved the conflicts. Some tests are failing, but it seems to be a configuration issue of the CUDA environment variables on Windows. Is this a known issue? |
80ed71c
to
b47456b
Compare
b47456b
to
602503b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls rebase your PR to latest code repo to trigger the CI test again.
0ac5b11
to
bebed30
Compare
bebed30
to
38cde29
Compare
38cde29
to
bc9ac29
Compare
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
bc9ac29
to
6e3ff93
Compare
Signed-off-by: Dan Hoeflinger <[email protected]>
A number of
onedpl_test_*
tests assume the presence of USM.This PR attempts to address the usage of
dpct::device_vector
anddpct::device_pointer
and assumptions that USM is available in a few ways:In
onedpl_test_copy_if
,onedpl_test_fill.cpp
,onedpl_test_sort_by_key.cpp
,onedpl_test_for_each.cpp
andonedpl_test_transform_reduce.cpp
: we change the usage pattern of some tests to usedpct::device_vector
in such a way to fit both USM and USM_NONE optionsIn
onedpl_test_exclusive_scan.cpp
,onedpl_test_fill.cpp
, andonedpl_test_sort_by_key.cpp
: we add checks to avoid some tests whenDPCT_USM_LEVEL_NONE
is defined.This PR also adds 2 tests which were missing from
help_function/help_function.xml
:onedpl_test_device_malloc_free
,and, but only to run for the option where USM is present.onedpl_test_transform
Edit: removing
onedpl_test_transform
as it is failing in all cases it seems. It seems this should be dealt with separately.This PR also changes
onedpl_test_uninitialized_fill
to only run with USM available, as all of its tests assume the USM is available.Closing #240 in favor of this PR which has a larger scope.