-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround Fetch Binary breaks with latest JPA HAPI FHIR Server #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
============================================
- Coverage 61.54% 61.34% -0.20%
- Complexity 206 208 +2
============================================
Files 16 16
Lines 1412 1428 +16
Branches 164 165 +1
============================================
+ Hits 869 876 +7
- Misses 458 467 +9
Partials 85 85 ☔ View full report in Codecov by Sentry. |
@ndegwamartin do we still need this? |
ndegwamartin
force-pushed
the
issue83-jpa-test
branch
from
November 27, 2024 16:03
263b17e
to
d8d48a7
Compare
- Throw illegal state exception on empty - Return null instead of syncstrategy id to empty list map
ndegwamartin
force-pushed
the
issue83-jpa-test
branch
from
November 27, 2024 16:06
d8d48a7
to
43def8a
Compare
dubdabasoduba
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Resolves #83
Fixes broken Assigned locations REL strategy sync
Engineer Checklist
bug fixes
option(s) on the
README.md
mvn spotless:check
to check my code follows the project'sstyle guide
mvn clean test jacoco:report
to confirm the coverage reportwas generated at
plugins/target/site/jacoco/index.html
mvn clean package
right before creating this pull request.