Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Fetch Binary breaks with latest JPA HAPI FHIR Server #84

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

ndegwamartin
Copy link
Collaborator

@ndegwamartin ndegwamartin commented Sep 10, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Resolves #83
Fixes broken Assigned locations REL strategy sync

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.34%. Comparing base (8b35a6f) to head (d9da604).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../fhir/gateway/plugins/PermissionAccessChecker.java 0.00% 13 Missing ⚠️
.../org/smartregister/fhir/gateway/plugins/Utils.java 85.71% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #84      +/-   ##
============================================
- Coverage     61.54%   61.34%   -0.20%     
- Complexity      206      208       +2     
============================================
  Files            16       16              
  Lines          1412     1428      +16     
  Branches        164      165       +1     
============================================
+ Hits            869      876       +7     
- Misses          458      467       +9     
  Partials         85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubdabasoduba
Copy link
Member

@ndegwamartin do we still need this?

@ndegwamartin ndegwamartin merged commit 3471eb3 into main Nov 28, 2024
1 of 3 checks passed
@ndegwamartin ndegwamartin deleted the issue83-jpa-test branch November 28, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch Binary breaks with latest JPA HAPI FHIR Server
3 participants