refactor: DockingDesktop #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## functional chnage - Remove static initialization of DockingUISettings and do it in the constructor ## Improve robustness - Check `currentState` nullity when access - Avoid always running debug logic - Change stateChange condition to be currentState != null ## initialize - Move fields initializer to constructor ## Define with lambda - Define PropertyChangeListener and ActionListener with lambda ## Optimize loop - Optimize if-else if-else blocks - Optimize for-loop ## Style - Remove redundant initializers - Optimize empty check with isEmpty() - clean unused local variable - javadoc: DockingDesktop - Simplify DockingDesktop#splitComponent method's stateChange local variable definition - Replace if block of String comparison to switch block in xmlCreateComponent private method
miurahr
added a commit
that referenced
this pull request
Sep 26, 2024
## Added * Respect `UIDefauls` table configuration defined in `LookAndFeel` class.(#11) * Allow a customization by inheriting `DockingUISettings` class and overide `getDefaults` method.(#11) ### Fixed * Avoid NPE when drag-n-drop with null hints (#9) ### Changed * Add GitHub Actions CI * Add SpotBugs and SpotLess code quality assurance * Style: spotless code format applied (#8) * feat: test UI behavior with Assertj-Swing-JUnit (#7) * refactor: annotate deprecations, avoid access to internal class of other class(#6) * refactor: avoid redundant casts (#6) * refactor: DockingDesktop class not to initialize in static context(#12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functional chnage
Improve robustness
currentStatenullity when accessinitialize
Define with lambda
Optimize loop
Style