forked from cmadsen/vldocking
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect UIDefaults configuraiton with custom LookAndFeel #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miurahr
force-pushed
the
topic/miurahr/respect-uidefaults
branch
from
September 23, 2024 09:14
072bfd7
to
7801199
Compare
miurahr
force-pushed
the
topic/miurahr/respect-uidefaults
branch
from
September 23, 2024 09:18
7801199
to
9b59391
Compare
- Introduce getDefaults(UIDefaults)/installUI(UIDefaults) method pair - Child class can override default values
- Explains UIDefualts friendly way
miurahr
force-pushed
the
topic/miurahr/respect-uidefaults
branch
from
September 24, 2024 09:33
ea80b24
to
8260ae4
Compare
miurahr
commented
Sep 25, 2024
miurahr
added a commit
that referenced
this pull request
Sep 26, 2024
## Added * Respect `UIDefauls` table configuration defined in `LookAndFeel` class.(#11) * Allow a customization by inheriting `DockingUISettings` class and overide `getDefaults` method.(#11) ### Fixed * Avoid NPE when drag-n-drop with null hints (#9) ### Changed * Add GitHub Actions CI * Add SpotBugs and SpotLess code quality assurance * Style: spotless code format applied (#8) * feat: test UI behavior with Assertj-Swing-JUnit (#7) * refactor: annotate deprecations, avoid access to internal class of other class(#6) * refactor: avoid redundant casts (#6) * refactor: DockingDesktop class not to initialize in static context(#12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vldocking UI customization deeply depends on
UIManager.put
overrides.It is better to respect
LookAndFeel
'sUIDefaults
configuration table when loading the developer defaults of the library.This proposal is to add functionality to check a predefined value in
UIDefaults defualts = UIManager.getDefaults()
configuration table. It also provides a way to override defaults in inherit aDockingUISettings
class and update values by overridegetDefaults
method.