Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect UIDefaults configuraiton with custom LookAndFeel #11

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Sep 23, 2024

The vldocking UI customization deeply depends on UIManager.put overrides.
It is better to respect LookAndFeel's UIDefaults configuration table when loading the developer defaults of the library.

This proposal is to add functionality to check a predefined value in UIDefaults defualts = UIManager.getDefaults() configuration table. It also provides a way to override defaults in inherit a DockingUISettings class and update values by override getDefaults method.

@miurahr miurahr force-pushed the topic/miurahr/respect-uidefaults branch from 072bfd7 to 7801199 Compare September 23, 2024 09:14
@omegat-org omegat-org deleted a comment from github-actions bot Sep 23, 2024
@omegat-org omegat-org deleted a comment from github-actions bot Sep 23, 2024
@omegat-org omegat-org deleted a comment from github-actions bot Sep 23, 2024
@omegat-org omegat-org deleted a comment from github-actions bot Sep 23, 2024
@miurahr miurahr force-pushed the topic/miurahr/respect-uidefaults branch from 7801199 to 9b59391 Compare September 23, 2024 09:18
@omegat-org omegat-org deleted a comment from github-actions bot Sep 23, 2024
@miurahr miurahr marked this pull request as ready for review September 23, 2024 09:25
@omegat-org omegat-org deleted a comment from github-actions bot Sep 23, 2024
@omegat-org omegat-org deleted a comment from github-actions bot Sep 23, 2024
@omegat-org omegat-org deleted a comment from github-actions bot Sep 23, 2024
- Introduce getDefaults(UIDefaults)/installUI(UIDefaults) method pair
- Child class can override default values
- Explains UIDefualts friendly way
@miurahr miurahr force-pushed the topic/miurahr/respect-uidefaults branch from ea80b24 to 8260ae4 Compare September 24, 2024 09:33
@miurahr miurahr merged commit c3c7f94 into master Sep 25, 2024
1 check passed
@miurahr miurahr deleted the topic/miurahr/respect-uidefaults branch September 25, 2024 22:45
miurahr added a commit that referenced this pull request Sep 26, 2024
## Added
* Respect `UIDefauls` table configuration defined in `LookAndFeel` class.(#11)
* Allow a customization by inheriting `DockingUISettings` class and overide `getDefaults` method.(#11)

### Fixed
* Avoid NPE when drag-n-drop with null hints (#9)

### Changed
* Add GitHub Actions CI
* Add SpotBugs and SpotLess code quality assurance
* Style: spotless code format applied (#8)
* feat: test UI behavior with Assertj-Swing-JUnit (#7)
* refactor: annotate deprecations, avoid access to internal class of other class(#6)
* refactor: avoid redundant casts (#6)
* refactor: DockingDesktop class not to initialize in static context(#12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant