-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.2][#1548] Install plugins from remote repository #226
base: master
Are you sure you want to change the base?
[6.2][#1548] Install plugins from remote repository #226
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
9236353
to
2e65928
Compare
Is there a reason why we don't have a milestone anymore? |
We need to have a discussion how to manage 3rd party plugin registry in core team or community, how to be a database format of 3rd party plugins, how to accept an addition/modification/removal request, how to decide accept or decline, how to remove an item from the list, etc.... |
Sure, but we can have that feature included in the code, and then start the discussion based on the feature requirements, don't you think so? Is that what is keeping you from "targeting" 6.1? |
- PluginInstaller: make it as singleton instance - Download remote plugin list when requested and keep it during session. Signed-off-by: Hiroshi Miura <[email protected]>
6249163
to
135352e
Compare
135352e
to
4f5e2b3
Compare
There is no consensus with you and core team to have an obligation of maintains certified plugin database on the web. Once the code included, above is forced to you with the assumptions of the code. OK, PLEASE maintain the database by @brandelune !? Is it what you want? @amake said
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Because we publish Current OmegaT versions on OmegaT web, |
Ok, let's have this discussion on the list. |
…ment # Conflicts: # src/org/omegat/Bundle.properties # src/org/omegat/gui/preferences/view/PluginsPreferencesController.java # src/org/omegat/util/OConsts.java
use remote plugin database as json format. Signed-off-by: Hiroshi Miura <[email protected]>
Update plugins.json download url. Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Now we have a JSON style database. |
Also allow localization of plugin category in the table. Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Improve "preferences > plugins" UI and localize type and status column. |
Signed-off-by: Hiroshi Miura <[email protected]>
Are there any good way to check downloaded jar file is not malformed using signature file jar.asc? |
Now "description" field is not localized. There is no specification how to define localized description in MANIFEST. |
PREFS_PLUGINS_COL_CATEGORY=Category | ||
PREFS_PLUGINS_COL_NAME=Name | ||
PREFS_PLUGINS_COL_VERSION=Version | ||
PREFS_PLUGINS_UPGRADE=Upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think update is better than upgrade:
- PREFS_PLUGIN_UPDATE=Update
PREFS_PLUGINS_INSTALL=Install | ||
|
||
PLUGIN_STATUS_BUNDLED=Bundled | ||
PLUGIN_STATUS_UPGRADABLE=Upgradable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following from the above:
- PLUGIN_STATUS_UPDATABLE=Update available
Updatable is better for the key name, but "update available" is more natural for users.
That might be a good question for the development list. I unfortunately don't know much about MANIFEST files, so I can't make any relevant suggestions. |
A more general comment: this looks much better than the current plugin UI. One question, though. How is the initial order of the plugins shown determined? It seems completely random, but it would probably be more user friendly to sort them by either category or name at first, until the user changes the sort order. |
Pull request type
Please check the type of change your PR introduces:
Which ticket is resolved?
Feature requests: https://sourceforge.net/p/omegat/feature-requests/1548/
Title: Plugin download and install manager
Preference->Plugin dialog show plugin information in 3-pain
Plugin preference table order (external first)
What does this PR change?
Other information
Plugin database is created as https://github.com/omegat-org/omegat-plugins/