Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter(po): plural as comment in japanese target #1165

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Oct 23, 2024

Japanese is nplural=1 language.
When there is no marker in singular msgid, translator can not see plural form of msgid when translate in OmegaT panes. This adds plural form of msgid as a comment of a segment which is a singular form.

Pull request type

  • Feature enhancement -> [enhancement]

Which ticket is resolved?

What does this PR change?

  • Add plural form of msgid string as comment when singular msgid is a source
  • Refactoring to replace String concatenation with "+" into "StringBuilder"

Other information

ref: discussion on https://sourceforge.net/p/omegat/bugs/1269/

Japanese is nplural=1 language.
When there is no marker in singular msgid, translator can not see plural form of msgid when translate in OmegaT panes.
This add plural form of msgid as a comment of a segment which is a singular form.

Signed-off-by: Hiroshi Miura <[email protected]>

This comment was marked as resolved.

@miurahr miurahr changed the title feat: filter(po): plural as comment in japanese feat: filter(po): plural as comment in japanese target Oct 23, 2024
@miurahr miurahr marked this pull request as ready for review October 24, 2024 09:50
Might as well fix this typo too while we're at it.
@miurahr miurahr added this to the 6.1.0 (Require Java 11) milestone Oct 30, 2024
Copy link

@brandelune brandelune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this modification will help the translator in the case at hand.
The resulting file will still trigger errors.

Also, in the case of plurals, their display location could be under the source, at the location of the alternative source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants