Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that axes MUST be a list of dictionaries #278

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dstansby
Copy link
Contributor

I think the intent with "It is a list of dicionaries" was a tight constraint, so I've replaced it with "MUST".

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Automated Review URLs

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dstansby.

0.5/index.bs Outdated Show resolved Hide resolved
@joshmoore
Copy link
Member

A few additional thoughts:

  • This and maybe a number of your other changes might also be good in 0.4. If you are interested, you might consider applying to both.
  • Any objections to batching them somewhat?
  • As we rightly add more MUSTs, is it worth having them all at the same level:
A foo is a $definition that:
 - MUST
 - MUST
 - SHOULD
 - SHOULD

etc.

@dstansby
Copy link
Contributor Author

This and maybe a number of your other changes might also be good in 0.4

I'm personally pretty strongly 👎 this, because a) updates to 0.x are not versioned and b) it becomes more work (even if updates are versioned) for implementations to target several moving versions of the spec, instead of one moving one (the latest version). So actually I think this change should go into 0.6, not in 0.5.

Any objections to batching them somewhat?

Nope, this is a great idea. I'll switch this to draft, go through and find similar updates, and then

As we rightly add more MUSTs, is it worth having them all at the same level:

👍

@joshmoore
Copy link
Member

So actually I think this change should go into 0.6, not in 0.5.

👍

Nope, this is a great idea. I'll switch this to draft, go through and find similar updates, and then

👍

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants