-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify multiscale and examples #172
base: main
Are you sure you want to change the base?
Conversation
Automated Review URLs |
Agreed.
Agreed. relation to coordinate systems
These two both interact with coordinate systems (CS) #138 . multiple "output" coordinate systems?There is a need to display / work with the same array data in different coordinate systems. So while there are indeed "No more top-level coordinateTransformations that apply to all elements of datasets.", constraints on
|
Agreed.
As John says, this gets more complicated when more types of transform are added (as do order constraints). If we're only ever going to use scale and translation, a convenient way to represent it would be
Agreed.
Agreed.
Agreed. |
Can you explain the problem with that affine transform? Is it just too much text or something? Because as long as consuming software can parse it, I don't see the problem. Someone could also throw in 100 chained identity transforms, but I don't think we need to put something in the spec suggesting that people refrain from this. |
This PR simplifies the multiscale metadata. A few highlights:
coordinateTransformations
that apply to all elements ofdatasets
. This is unneeded, because we can convey the exact same information via thecoordinateTransformations
field for each element ofdatasets
.scale
andtranslation
transformations are required for each element ofdatasets
. Reasoning for this decision is added to the spec.type
field ofmultiscales
is removed. A better place for that information is inside themetadata
field.version
field ofmultiscales
is now required. If this is optional, it causes headaches for implementations / parsers, and the version should always be defined anyway, so we should mandate it.