fix: properly start a session from Telescope #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly starts sessions loaded from another directory using Telescope. Crucially, this version compares the working directory of the session, not the working directory at the time of the session load, to the lists of allowed and ignored directories.
oldenj
commented
May 31, 2024
| vim.g.persisting_session = config.options.follow_cwd and nil or session | ||
| utils.load_session(session, config.options.silent) | ||
| elseif type(config.options.on_autoload_no_session) == "function" then | ||
| config.options.on_autoload_no_session() | ||
| end | ||
| end | ||
|
|
||
| dir = session_dir() |
There was a problem hiding this comment.
This somewhat changes the logic.
If a user has follow_cwd = false, there might be a session file that is being loaded from directory A, but session_dir() after loading the session might return directory B.
In the case of opening via Telescope, I think it's clear that directory B should be tested against allow/ignore list.
The other case is not as clear.
|
Amazing thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly starts sessions loaded from another directory using Telescope. Crucially, this version compares the working directory of the session, not the working directory at the time of the session load, to the lists of allowed and ignored directories.