Refactor and use go only #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoshsadiq
commented
Jul 31, 2024
hoshsadiq
commented
Jul 31, 2024
go.mod
Outdated
|
|
||
| require golang.org/x/text v0.16.0 | ||
|
|
||
| require github.com/hoshsadiq/godotenv v1.0.0 // indirect |
There was a problem hiding this comment.
I used my custom fork of https://github.com/joho/godotenv/ which parses things a lot better. But happy to switch it back to https://github.com/joho/godotenv/, or another one if you have a preference.
hoshsadiq
commented
Jul 31, 2024
Comment on lines
+60
to
+64
| if [ ! -z "$OKTETO_CA_CERT" ]; then | ||
| echo "Custom certificate is provided" | ||
| echo "$OKTETO_CA_CERT" > /usr/local/share/ca-certificates/okteto_ca_cert.crt | ||
| update-ca-certificates | ||
| fi |
There was a problem hiding this comment.
I'm unsure where this is used, so haven't made the relevant changes yet.
There was a problem hiding this comment.
This is to support the scenario where Okteto is using a private CA or a self-signed certificate
hoshsadiq
commented
Jul 31, 2024
| "PreviewURLSuffix": previewURLSuffix, | ||
| "PreviewSuccess": previewSucceeded, | ||
| "Endpoints": endpoints, | ||
| "EndpointsMap": getEndpointsMap(previewURLSuffix, endpoints), |
There was a problem hiding this comment.
This is useful in cases like this:
### :rocket: [Open MyApp]({{ index .EndpointsMap "app" }}) :rocket:
Supporting services are available at the following links:
- [Minio]({{ index .EndpointsMap "minio" }}) - the minio s3 emulator.
- [Database UI]({{ index .EndpointsMap "adminer" }}) - Database editor.Which would translate to something like this:
🚀 Open MyApp 🚀
Supporting services are available at the following links:
- Minio - the minio s3 emulator.
- Database UI - Database editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the whole repo and uses go only (where previously it was using bash, go, and ruby). This also adds an extra option to customise the comment that the bot leaves on a PR, which was the main reason I started making changes to the repo.
I've also set it up in a way where it should be easy to add support for additional CI environments.