Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the rotation of bottom parts in the generated centroid.
Caution
This is a breaking change. All PCBA made with ERB needs to fix their rotation when using bottom parts, for parts for which orientation is critical. This won't affect resistors or non-polarised capacitors.
We tested this with 3 parts:
We did a test file with all 4 rotations on each side, then compared.
(the misaligned pads seem to be a weird bug in JLCPCB preview for some reason. The gerbers were fine, and we were only considering the centroid anyway)