Make util_ns fields: run and is_initialized atomics #10570
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dariusz Sciebura <[email protected]>
dsciebu
changed the title
shefty
reviewed
Nov 22, 2024
| return; | ||
|
|
||
| ofi_atomic_initialize32(&ns->ref, 0); | ||
| ns->listen_sock = INVALID_SOCKET; | ||
| if (!ns->hostname) | ||
| ns->hostname = OFI_NS_DEFAULT_HOSTNAME; | ||
| ns->is_initialized = 1; | ||
| ofi_atomic_set32(&ns->is_initialized, 1); |
There was a problem hiding this comment.
The name service is basically a simple way to support running fabtests. It's not something we expect to have enabled as a general purpose feature.
If it were, the changes here are not sufficient to support multiple threads. Locks would be needed. It's ultimately the responsibility of the caller to have appropriate serialization to the name service calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values of util_ns fields can be read/write in parallel from multiple threads. Making them atomics secures these kind of access.
Signed-off-by: Dariusz Sciebura [email protected]