[draft] Implement the popover API.
#1734
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainBoilard
commented
Nov 15, 2024
Comment on lines
+758
to
+767
| method showPopover : unit meth | ||
|
|
||
| method showPopover_options : _ -> unit meth | ||
|
|
||
| method togglePopover : bool t meth | ||
|
|
||
| method togglePopover_force : bool t -> bool t meth | ||
|
|
||
| method togglePopover_options : _ -> bool t meth | ||
|
|
There was a problem hiding this comment.
According to the specs, these methods accept a dictionary as a parameter for passing options. How would that be reflected in Js_of_ocaml?
SylvainBoilard
commented
Nov 15, 2024
Comment on lines
+560
to
+563
| method onbeforetoggle : ('self t, toggleEvent t) event_listener writeonly_prop | ||
|
|
||
| method ontoggle : ('self t, toggleEvent t) event_listener writeonly_prop | ||
|
|
There was a problem hiding this comment.
There are similar methods related to event handlers in this file that have the prop type instead of writeonly_prop. In fact, the ontoggle method initially used the former type. Is this new version correct?
This was referenced Nov 15, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds support for the
popoverAPI.See:
Please let me know of any issue; in fact, I would appreciate your input regarding a couple things (see below).
Cheers,