Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate URLBuilder in favor of AddressBuilder. #272

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Commits on Sep 12, 2018

  1. Deprecate URLBuilder in favor of AddressBuilder.

    These are the last two internal use cases for URLBuilder.  And replacing
    them makes my IDE happy.  Both are similar to the create case but
    different.
    
    InboundRewriteRuleAdaptor needs the encoding.
    RewriteViewHandler needs to merge two query strings.
    Matt Fletcher authored and Matt Fletcher committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    f816724 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. Fix path encoding.

    Matt Fletcher authored and Matt Fletcher committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    07c526e View commit details
    Browse the repository at this point in the history
  2. Encode before parsing as URI

    If we send an invalid URL to the URI parser, it falls over and fails.
    But apparently we are supposed to accept and fix rules that produce
    invalid URLs.  So encode URL before we try to parse it.
    Matt Fletcher authored and Matt Fletcher committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    ad64af0 View commit details
    Browse the repository at this point in the history
  3. Join manually before Java8

    String.join did not exist prior to Java 8.  So implement manually with
    StringBuilder.
    Matt Fletcher authored and Matt Fletcher committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    0cd3eda View commit details
    Browse the repository at this point in the history
  4. Fix incorrect index

    Matt Fletcher authored and Matt Fletcher committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    647296a View commit details
    Browse the repository at this point in the history
  5. Escape the question mark

    Use Pattern.quote to escape the question mark and use it literally.
    Matt Fletcher authored and Matt Fletcher committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    216db82 View commit details
    Browse the repository at this point in the history
  6. Make clearer what it is doing

    Since both pathEncoded and pathDecoded decode the string, use
    pathDecoded so people will know what's happening.
    Matt Fletcher authored and Matt Fletcher committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    ee978fd View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2018

  1. Add message to assertion

    As this test is not failing locally and not producing useful information
    on Travis, adding a message to the failing assertion.
    Matt Fletcher authored and Matt Fletcher committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    af17ced View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. Remove duplicate casts

    We cast event to HttpServletRewrite before getting the inbound address.
    We do not need to keep doing it, as we have the cast version stored.
    Matt Fletcher authored and Matt Fletcher committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    6f66abf View commit details
    Browse the repository at this point in the history