-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate URLBuilder in favor of AddressBuilder. #272
Open
mdfst13
wants to merge
9
commits into
ocpsoft:main
Choose a base branch
from
mdfst13:url-builder-deprecation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 12, 2018
-
Deprecate URLBuilder in favor of AddressBuilder.
These are the last two internal use cases for URLBuilder. And replacing them makes my IDE happy. Both are similar to the create case but different. InboundRewriteRuleAdaptor needs the encoding. RewriteViewHandler needs to merge two query strings.
Matt Fletcher authored and Matt Fletcher committedSep 12, 2018 Configuration menu - View commit details
-
Copy full SHA for f816724 - Browse repository at this point
Copy the full SHA f816724View commit details
Commits on Sep 13, 2018
-
Matt Fletcher authored and Matt Fletcher committed
Sep 13, 2018 Configuration menu - View commit details
-
Copy full SHA for 07c526e - Browse repository at this point
Copy the full SHA 07c526eView commit details -
If we send an invalid URL to the URI parser, it falls over and fails. But apparently we are supposed to accept and fix rules that produce invalid URLs. So encode URL before we try to parse it.
Matt Fletcher authored and Matt Fletcher committedSep 13, 2018 Configuration menu - View commit details
-
Copy full SHA for ad64af0 - Browse repository at this point
Copy the full SHA ad64af0View commit details -
String.join did not exist prior to Java 8. So implement manually with StringBuilder.
Matt Fletcher authored and Matt Fletcher committedSep 13, 2018 Configuration menu - View commit details
-
Copy full SHA for 0cd3eda - Browse repository at this point
Copy the full SHA 0cd3edaView commit details -
Matt Fletcher authored and Matt Fletcher committed
Sep 13, 2018 Configuration menu - View commit details
-
Copy full SHA for 647296a - Browse repository at this point
Copy the full SHA 647296aView commit details -
Use Pattern.quote to escape the question mark and use it literally.
Matt Fletcher authored and Matt Fletcher committedSep 13, 2018 Configuration menu - View commit details
-
Copy full SHA for 216db82 - Browse repository at this point
Copy the full SHA 216db82View commit details -
Since both pathEncoded and pathDecoded decode the string, use pathDecoded so people will know what's happening.
Matt Fletcher authored and Matt Fletcher committedSep 13, 2018 Configuration menu - View commit details
-
Copy full SHA for ee978fd - Browse repository at this point
Copy the full SHA ee978fdView commit details
Commits on Sep 16, 2018
-
As this test is not failing locally and not producing useful information on Travis, adding a message to the failing assertion.
Matt Fletcher authored and Matt Fletcher committedSep 16, 2018 Configuration menu - View commit details
-
Copy full SHA for af17ced - Browse repository at this point
Copy the full SHA af17cedView commit details
Commits on Sep 18, 2018
-
We cast event to HttpServletRewrite before getting the inbound address. We do not need to keep doing it, as we have the cast version stored.
Matt Fletcher authored and Matt Fletcher committedSep 18, 2018 Configuration menu - View commit details
-
Copy full SHA for 6f66abf - Browse repository at this point
Copy the full SHA 6f66abfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.