Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use createAsset util function from ocean.js. #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mariacarmina
Copy link
Member

Fixes #11 .

Changes proposed in this PR:

  • Use createAsset util function from ocean.js.
  • Change params order
  • Update to latest version of ocean.js

@mariacarmina mariacarmina self-assigned this Nov 5, 2024
@mariacarmina
Copy link
Member Author

@jamiehewitt15 should we create a separate issue for integrating support for sapphire, meaning datatoken template id 4 and accesslist factory?
I wouldn't include the oasis integration in this PR.

@jamiehewitt15
Copy link
Member

@jamiehewitt15 should we create a separate issue for integrating support for sapphire, meaning datatoken template id 4 and accesslist factory? I wouldn't include the oasis integration in this PR.

Yeah, let's do it seperately

@jamiehewitt15
Copy link
Member

I tested it locally barge and got this error. Do you know what might be causing this?

image

@mariacarmina
Copy link
Member Author

I tested it locally barge and got this error. Do you know what might be causing this?

image

That error comes from latest release of ocean.js, make sure that the chain ID from the json sample matches the network configured (8996).

@jamiehewitt15
Copy link
Member

I updated the metadata to have the right chainId, but now I'm getting another error. Have you seen this before?

image

@mariacarmina
Copy link
Member Author

mariacarmina commented Nov 19, 2024

I updated the metadata to have the right chainId, but now I'm getting another error. Have you seen this before?

image

We have a separate issue for this where accesslists will be integrated #16, let me double check why that address error is popping up.

@jamiehewitt15
Copy link
Member

We have a separate issue for this where accesslists will be integrated #16, let me double check why that address error is popping up.

Ok, we should still be able to publish assets on barge though?

@mariacarmina
Copy link
Member Author

We have a separate issue for this where accesslists will be integrated #16, let me double check why that address error is popping up.

Ok, we should still be able to publish assets on barge though?

Yes, of course, I think the way that we retrive the contract addresses makes that error occur.

@jamiehewitt15
Copy link
Member

Yes, of course, I think the way that we retrive the contract addresses makes that error occur.

Ok, so we need to fix that first then...

@mariacarmina
Copy link
Member Author

Hello @jamiehewitt15:

extensionHostProcess.js:162
Finding the service endpoints failed: FetchError {message: 'request to https://node5.oceanprotocol.com:8…on: connect ECONNREFUSED 34.122.123.116:8000', type: 'system', errno: 'ECONNREFUSED', code: 'ECONNREFUSED', stack: 'FetchError: request to https://node5.oceanpro…ons (node:internal/process/task_queues:82:21)'}
extensionHostProcess.js:162
Error details: Error: HTTP request failed calling Provider {stack: 'Error: HTTP request failed calling Provider
	…vscode-extension/dist/extension.js:122:48789)', message: 'HTTP request failed calling Provider'}

I did not receive the error with accessListFactory address, I used ocean-lib v3.4.4., used remote node on sepolia

@jamiehewitt15
Copy link
Member

Still getting the same error:

image

Testing locally with barge, which is working fine on the main branch.

@mariacarmina
Copy link
Member Author

I think it is coming from some setup error w barge, on optimism sepolia, I could've published without problems the asset.
Screenshot 2024-11-25 at 14 57 01
DID published on op. sepolia: did:op:ba6518f6d3b7b6e41293bdf57a02aed11dbbf0c7a51272dd77e4cf246447321a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use createAsset utility function from ocean.js
2 participants