Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C2D V2 fixes #72

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

C2D V2 fixes #72

wants to merge 8 commits into from
+763 −665

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Nov 5, 2024 •
edited
Loading

Fixes # .

Changes proposed in this PR:
Needed for testing C2D V2

@paulo-ocean paulo-ocean changed the title minor fix on type, add missing fields C2D V2 fixes Nov 5, 2024
@jamiehewitt15
Copy link
Member

Let's focus on testing and fixing the bugs in the PR on the node (oceanprotocol/ocean-node#705) first.

@paulo-ocean
Copy link
Contributor Author

Let's focus on testing and fixing the bugs in the PR on the node (oceanprotocol/ocean-node#705) first.

Ok, but these changes are needed, don't just think in terms of directCommand ... all these changes + the SDK are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 will be requested when the pull request is marked ready for review alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas will be requested when the pull request is marked ready for review bogdanfazakas is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 will be requested when the pull request is marked ready for review jamiehewitt15 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina will be requested when the pull request is marked ready for review mariacarmina is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulo-ocean @jamiehewitt15