Error printing tests #173
Merged
Error printing tests #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
requested review from
NathanReb and
panglesd
as code owners
Leonidas-from-XIV
added
the
no changelog
Leonidas-from-XIV
force-pushed
the
error-printing-tests
branch
from
7af2c4c
to
bdca9d8
Compare
This makes it easier to understand where names are from, in most cases the only used function was `sprintf`
Leonidas-from-XIV
force-pushed
the
error-printing-tests
branch
from
e57b94b
to
1ea182c
Compare
Leonidas-from-XIV
merged commit 768ee8f
into
ocaml-community:master
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few regression tests to make sure the printing of error location doesn't break when working on the code. One of the tests shows even that the printing is off and needs to be fixed, so I marked it that it is buggy (and might push a fix for it later, but I feel this is already useful as-is).