OpenVino support for yolov8 object detection #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhaval-zala thank you for this great contribution! Can you please fix the conflicting file? |
fcakyon
requested changes
Nov 5, 2023
|
@fcakyon I'll resolve it soon. |
fcakyon
reviewed
Nov 6, 2023
sahi/auto_model.py
Outdated
| @@ -3,6 +3,7 @@ | |||
| from sahi.utils.file import import_model_class | |||
|
|
|||
| MODEL_TYPE_TO_MODEL_CLASS_NAME = { | |||
| "yolov8Vino": "Yolov8DetectionVinoModel", | |||
There was a problem hiding this comment.
Suggested change
| "yolov8Vino": "Yolov8DetectionVinoModel", | |
| "yolov8openvino": "Yolov8OpenvinoDetectionModel", |
fcakyon
reviewed
Nov 6, 2023
sahi/models/base.py
Outdated
| @@ -49,6 +50,8 @@ def __init__( | |||
| self.config_path = config_path | |||
| self.model = None | |||
| self.device = device | |||
| if ".xml" == self.model_path[-4:]: | |||
There was a problem hiding this comment.
Please don't change the base class, move these operations to Yolov8OpenvinoDetectionModel class
fcakyon
reviewed
Nov 6, 2023
sahi/models/base.py
Outdated
Comment on lines
63
to
64
| if not ".xml" == self.model_path[-4:]: | ||
| self.set_device() |
There was a problem hiding this comment.
Please don't change the base class, move these operations to Yolov8OpenvinoDetectionModel class
fcakyon
reviewed
Nov 6, 2023
sahi/models/yolov8Vino.py
Outdated
Comment on lines
4
to
5
| from openvino.runtime import Core | ||
| from openvino.runtime import Core, AsyncInferQueue |
There was a problem hiding this comment.
these should be imported during function call
fcakyon
reviewed
Nov 6, 2023
sahi/models/yolov8Vino.py
Outdated
| # self.output = None | ||
|
|
||
| def check_dependencies(self) -> None: | ||
| check_requirements(["ultralytics"]) |
There was a problem hiding this comment.
openvino req should be included
fcakyon
reviewed
Nov 6, 2023
sahi/utils/yolov8.py
Outdated
| @@ -2,6 +2,7 @@ | |||
| from os import path | |||
| from pathlib import Path | |||
| from typing import Optional | |||
| from ultralytics import YOLO | |||
There was a problem hiding this comment.
this import should be moved inside to test
fcakyon
reviewed
Nov 6, 2023
sahi/utils/yolov8.py
Outdated
| def download_yolov8l_model(destination_path: Optional[str] = None): | ||
| if destination_path is None: | ||
| destination_path = Yolov8TestConstants.YOLOV8L_MODEL_PATH | ||
| def OpenVino_yolov8s_model(yolov8s_model_path: Optional[str] = None): |
There was a problem hiding this comment.
Suggested change
| def OpenVino_yolov8s_model(yolov8s_model_path: Optional[str] = None): | |
| def download_yolov8s_openvino_model(yolov8s_model_path: Optional[str] = None): |
fcakyon
reviewed
Nov 6, 2023
sahi/utils/yolov8.py
Outdated
| def download_yolov8m_model(destination_path: Optional[str] = None): | ||
| if destination_path is None: | ||
| destination_path = Yolov8TestConstants.YOLOV8M_MODEL_PATH | ||
| def OpenVino_yolov8n_model(yolov8n_model_path: Optional[str] = None): |
There was a problem hiding this comment.
Suggested change
| def OpenVino_yolov8n_model(yolov8n_model_path: Optional[str] = None): | |
| def download_yolov8n_openvino_model(yolov8n_model_path: Optional[str] = None): |
fcakyon
reviewed
Nov 6, 2023
sahi/models/yolov8Vino.py
Outdated
| from sahi.utils.import_utils import check_requirements | ||
|
|
||
|
|
||
| class Yolov8DetectionVinoModel(DetectionModel): |
There was a problem hiding this comment.
Suggested change
| class Yolov8DetectionVinoModel(DetectionModel): | |
| class Yolov8OpenvinoDetectionModel(DetectionModel): |
dhaval-zala
commented
Nov 8, 2023
fcakyon
requested changes
May 20, 2024
There was a problem hiding this comment.
Please fix the code formatting, add unit tests and a demo notebook @dhaval-zala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added OpenVino for Yolov8 object detection. It will optimise the CPU usage. OpenVino allows to run model in intel CPU with less CPU consumption. This will create great impact on get_sliced_prediction in terms of cpu utilization.