Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Bump CEF/Chromium from 4638 (95) to 5060 (103) #6867

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

WizardCM
Copy link
Member

@WizardCM WizardCM commented Jul 30, 2022

Description

This updates the browser dependency used by obs-browser from Chromium 95 to Chromium 103. This is the last Chromium version that supports the particular texture sharing we use, so we may be stuck here a while - not sure yet.

This update includes:

  • Texture sharing patches for macOS and Windows
  • Jim's legendary texture fix on Windows
  • Audio monitoring support

This update removes/excludes (due to limited time & added complexity):

  • MediaHandler API

obsproject/cef@4204d54

Motivation and Context

Ideally we want Chromium to be as up to date as possible, to ensure a bug free experience for users.

It's worth noting that we don't actually know why the above linked bug is fixed in this version. It was definitely still broken in Chromium 102, and nothing was specifically done to alleviate the issue.

Many thanks to @pkviet on adapting patches for each Chromium version and building across all platforms.

How Has This Been Tested?

  • Loaded chrome://version, chrome://gpu, YouTube and some WebGL demos in browser sources
  • Loaded various webpages in browser docks

Note: Windows x86 has been tested via CI. macOS Intel over CI seems to hang on shutdown?

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added Enhancement Improvement to existing functionality Seeking Testers Build artifacts on CI labels Jul 30, 2022
@WizardCM WizardCM merged commit 577b11e into obsproject:master Jul 30, 2022
@WizardCM WizardCM deleted the cef-5060-update branch July 30, 2022 23:46
@RytoEX RytoEX added this to the OBS Studio 28.0 milestone Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality Seeking Testers Build artifacts on CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visuals Stop Rendering When Source is Repeatedly Refreshed
2 participants