Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp-services: Add SOOP Global #11542

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Fortune-SOOP
Copy link

@Fortune-SOOP Fortune-SOOP commented Nov 21, 2024

Description

Added 'SOOP Global' to stream service options.

Motivation and Context

SOOP Global is a global platform created by the same company as SOOP Korea (formerly AfreecaTV).
It launched in beta on May 30, 2024, and is set for its official launch on November 22, 2024.
To provide more options for streamers on SOOP Global, the platform is introducing an RTMP service.

How Has This Been Tested?

Locally tested and is working properly.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Fenrirthviti
Copy link
Member

This is now the 4th PR opened, after being initially rejected for lack of visible platform adoption.

Please stop closing and creating new PRs.

@Fortune-SOOP
Copy link
Author

Fortune-SOOP commented Nov 21, 2024

This is now the 4th PR opened, after being initially rejected for lack of visible platform adoption.

Please stop closing and creating new PRs.
@Fenrirthviti

SOOP Global is primarily a platform where streamers from the Thailand region are most active.
Currently, there aren’t many users online, but user activity significantly increases around 11:00 (UTC+0).

Additionally, the platform holds exclusive broadcasting rights for the Riot Valorant SEA tournament, with many streamers co-streaming the related content.

Please review this information again.

@Fenrirthviti
Copy link
Member

Fenrirthviti commented Nov 21, 2024

I will reopen this and review again at the times mentioned, but please do not close/reopen a new PR. You can force push changes that are necessary without needing to open a new PR. If you need assistance in how to use git or github, we would prefer that you just ask for guidance.

@Fenrirthviti Fenrirthviti reopened this Nov 21, 2024
@Fenrirthviti
Copy link
Member

To that end, the commit title still does not conform with our commit guidelines, and this is still missing the package version increase. Please review another example of a successfully merged services PR (such as #11104 or #10869) for examples on how this should be accomplished.

I will also link the streaming service submission guidelines for additional context.

@Fortune-SOOP
Copy link
Author

I’m sorry for repeatedly opening PRs with the same content. I’ll be more careful next time.
I’ll reach out if I need any help. Thank you!

@Fortune-SOOP Fortune-SOOP changed the title Add SOOP Global RTMP service rtmp-services: Add SOOP Global Nov 21, 2024
@Fortune-SOOP Fortune-SOOP marked this pull request as ready for review November 21, 2024 08:13
@AGPumBoy
Copy link

I hope you will take note of this comment.

Here is an example of #11433 that I posted before.
If I may give my opinion, I think that even though the broadcast platform has been officially opened, the number of viewers is still low. As of 11:21 UTC, 7376 people are watching the broadcast on that platform.

If you watch for 24 hours, the maximum number of people is, from what I remember, 8,000 to 9,000. If it's small, it's 2,000 based on the entire live streaming broadcast.

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants