Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Reorganize Preview/Source context menu #11492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Warchamp7
Copy link
Member

Description

Reorganizes the order of menu items in the Preview and Source right-click context menus. On top of adjustments to menu entry order, functional changes are:

  • Copy filters / Paste filters only shown in the sources dock menu and only when a source is selected
  • Copy only shown when a source is selected
  • Set Color removed from preview menus
  • Hide in Mixer removed from preview menus
  • Projector menus are now all a single submenu instead of a fullscreen submenu and a separate windowed entry

Motivation and Context

A lot of entries in the preview context menu have been added over time and their order and position are only loosely tied together.

While there is no perfect ordering or grouping here due to overlapping contexts and functionality. This reorganizes the menu to be a bit more thoughtful.

Preview (No source selected)

Before After
obs64_9uJT5TnSsc obs64_LVkqb6jCt9

Sources dock (No source selected)

Before After
obs64_i6nNj1GbFJ obs64_EkMnBglVNU

Preview (Source selected)

Before After
obs64_e2hXCMFpXr obs64_txIvcJ7ogv

Sources dock (Source selected)

Before After
obs64_7jZ0mbyw2D obs64_Hh2G3VmPUv

How Has This Been Tested?

Checked all the menu options still behaved as expected.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added Enhancement Improvement to existing functionality UI/UX Anything to do with changes or additions to UI/UX elements. labels Nov 5, 2024
@Warchamp7 Warchamp7 force-pushed the preview-context-menu branch 2 times, most recently from 63c87d0 to 64ff8e5 Compare November 6, 2024 00:12
@Warchamp7 Warchamp7 force-pushed the preview-context-menu branch 2 times, most recently from 6bda60d to b29d332 Compare November 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants