-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rtmp-services : Change the server URL of AfreecaTV to SOOP Korea #11428
Conversation
e are planning to change the server URL of AfricaTV to SOOP.
change the server URL of AfricaTV to SOOP.
|
@notr1ch I modified it. Thank you. |
@notr1ch |
The alt_names are still not correct and the commits should be squashed and correctly formatted to the service submission guidelines. |
As an additional note, services are updated independently of OBS releases. This does not need to be merged for a specific release, and would be live 24~ hours after merging. |
@notr1ch I fixed it. Please review it. |
You have introduced 10 superfluous commits that need to be squashed. Please squash the commits and follow the correct commit guidelines. |
I'm requesting a new one because the commit arrangement is complicated. (#11550) |
In the future, we strongly prefer that if you don't know how to use git, to please just ask us for assistance. Between this and the SOOP global PR, you have generated nearly half of the github email traffic I've had to sort through this week. Any further failure to follow proper developer etiquette, our processes, or documentation may result in the changes being rejected, and SOOP removed from our services list entirely. |
@Fenrirthviti Sorry, This was my first time working on it. I'll keep the guide well from now on. |
Description
Effective October 15th, our service has been rebranded from Afreecatv to SOOP Korea.
We are planning to change the server URL of AfreecaTV to SOOP Korea.
Motivation and Context
We aim to adapt the current Afreecatv configurations to be compatible with SOOP.
How Has This Been Tested?
Locally tested and is working properly.
Types of changes
Breaking change (fix or feature that would cause existing functionality to change)
Checklist: