Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp-services : Change the server URL of AfreecaTV to SOOP Korea #11428

Closed
wants to merge 13 commits into from

Conversation

Taeski-SOOP
Copy link

Description

Effective October 15th, our service has been rebranded from Afreecatv to SOOP Korea.
We are planning to change the server URL of AfreecaTV to SOOP Korea.

Motivation and Context

We aim to adapt the current Afreecatv configurations to be compatible with SOOP.

How Has This Been Tested?

Locally tested and is working properly.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

e are planning to change the server URL of AfricaTV to SOOP.
change the server URL of AfricaTV to SOOP.
@WizardCM WizardCM added the Services These are modifications to the Service list and are not tied to the release schedule label Oct 21, 2024
@notr1ch
Copy link
Member

notr1ch commented Oct 21, 2024

alt_names is intended to be used for migration from old service names - in this case, alt_names should be Afreeca.TV and AfreecaTV as these are the only prior names this service is known as.

@Taeski-SOOP
Copy link
Author

Taeski-SOOP commented Oct 22, 2024

@notr1ch I modified it. Thank you.

@Taeski-SOOP
Copy link
Author

@notr1ch
Hi, notr1ch. I have a question.
I wonder if that request can be included in OBS Studio 31.
Also, I would like to know the release date of OBS Studio 31.

@notr1ch
Copy link
Member

notr1ch commented Nov 20, 2024

The alt_names are still not correct and the commits should be squashed and correctly formatted to the service submission guidelines.

@Fenrirthviti
Copy link
Member

As an additional note, services are updated independently of OBS releases. This does not need to be merged for a specific release, and would be live 24~ hours after merging.

@Taeski-SOOP Taeski-SOOP changed the title Update services.json : Change the server URL of AfreecaTV to SOOP Korea rtmp-services : Change the server URL of AfreecaTV to SOOP Korea Nov 21, 2024
@Taeski-SOOP
Copy link
Author

@notr1ch I fixed it. Please review it.

@Fenrirthviti
Copy link
Member

You have introduced 10 superfluous commits that need to be squashed. Please squash the commits and follow the correct commit guidelines.

@Taeski-SOOP
Copy link
Author

I'm requesting a new one because the commit arrangement is complicated. (#11550)

@Fenrirthviti
Copy link
Member

In the future, we strongly prefer that if you don't know how to use git, to please just ask us for assistance.

Between this and the SOOP global PR, you have generated nearly half of the github email traffic I've had to sort through this week. Any further failure to follow proper developer etiquette, our processes, or documentation may result in the changes being rejected, and SOOP removed from our services list entirely.

@Taeski-SOOP
Copy link
Author

@Fenrirthviti Sorry, This was my first time working on it. I'll keep the guide well from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Services These are modifications to the Service list and are not tied to the release schedule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants