Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2251 obsolete increased nucleus size #2268

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

aleixpuigb
Copy link
Collaborator

Fixes #2251 obsolete increased nucleus size

@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-01-22/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-01-22/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

increased nucleus size http://purl.obolibrary.org/obo/CL_0017505

Removed

Added

lymphocyte http://purl.obolibrary.org/obo/CL_0000542

Removed

myeloblast http://purl.obolibrary.org/obo/CL_0000835

Removed

proerythroblast http://purl.obolibrary.org/obo/CL_0000547

Removed

promyelocyte http://purl.obolibrary.org/obo/CL_0000836

Removed

Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

increased nucleus size http://purl.obolibrary.org/obo/CL_0017505

Removed

Added

lymphocyte http://purl.obolibrary.org/obo/CL_0000542

Removed

Added

myeloblast http://purl.obolibrary.org/obo/CL_0000835

Removed

Added

proerythroblast http://purl.obolibrary.org/obo/CL_0000547

Removed

Added

promyelocyte http://purl.obolibrary.org/obo/CL_0000836

Removed

Added


AnnotationAssertion(Annotation(oboInOwl:hasDbXref "GOC:tfm") obo:IAO_0000115 obo:CL_0017505 "A nucleus size quality which is relatively high compared to the amount of cytoplasm present in the same cell.")
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "GOC:tfm") obo:IAO_0000115 obo:CL_0017505 "OBSOLETE. A nucleus size quality which is relatively high compared to the amount of cytoplasm present in the same cell.")
AnnotationAssertion(obo:IAO_0000233 obo:CL_0017505 "https://github.com/obophenotype/cell-ontology/issues/2251")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this URL as IRI.

dosumis
dosumis previously approved these changes Jan 22, 2024
Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once you've fixed the data type issue Anita found.

@aleixpuigb aleixpuigb merged commit 198f9cd into master Jan 22, 2024
1 check passed
@aleixpuigb aleixpuigb deleted the 2251_obsolete_increased_nucleus_size branch January 22, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

obsolete increased nucleus size
3 participants