Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label synonym polysemy check #2112

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Add label synonym polysemy check #2112

merged 4 commits into from
Sep 1, 2023

Conversation

anitacaron
Copy link
Contributor

@anitacaron anitacaron commented Aug 18, 2023

This is the same check available in Uberon.

Currently, this check has two violations as already raised in the issue

FAIL Rule ../sparql/label-synonym-polysemy-violation.sparql: 2 violation(s)
entity,property,value
http://purl.obolibrary.org/obo/CL_0002294,http://www.geneontology.org/formats/oboInOwl#hasExactSynonym,subcapsular thymic epithelial cell
http://purl.obolibrary.org/obo/CL_0009077,http://www.w3.org/2000/01/rdf-schema#label,subcapsular thymic epithelial cell

@anitacaron anitacaron self-assigned this Aug 18, 2023
@anitacaron
Copy link
Contributor Author

The two violations need to be fixed for this PR can be merged.

@ghost ghost linked an issue Aug 18, 2023 that may be closed by this pull request
@ghost
Copy link

ghost commented Aug 31, 2023

@anitacaron, #2101 has been resolved. Can you proceed with the linked PR or is it also dependent on #2102?

@anitacaron
Copy link
Contributor Author

@bvarner-ebi, this doesn't depend on #2102 because it's already on the ROBOT report as WARN.

Now, after updating the branch from master, it just need to pass the checks and it can be merged.

@anitacaron anitacaron requested review from aleixpuigb and a user September 1, 2023 13:28
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally.
Expected output observed.
Thanks, @anitacaron!

@anitacaron anitacaron merged commit 4256b6f into master Sep 1, 2023
1 check passed
@anitacaron anitacaron deleted the anitacaron/issue2111 branch September 29, 2023 10:25
@aleixpuigb aleixpuigb removed their request for review October 31, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add synonym QC check to CL
1 participant