[wip] Correct scanning of non-PCI network devices #1185
Conversation
Non-PCI network devices (present usually on IBM Z architecture) does not have ID_VENDOR_ID attribute and also there is nothing we could put into Interface.pci_info about them. For such devices, set empty string for Interface.vendor field and None value for pci_info. The Interface model has been updated, allowing None value for pci_info field.
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp, e.g. from PR#42, use It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
Co-authored-by: Michal Hečko <[email protected]>
| @@ -42,9 +42,13 @@ def interfaces(): | |||
| attrs['name'] = dev.sys_name | |||
| attrs['devpath'] = dev.device_path | |||
| attrs['driver'] = dev['ID_NET_DRIVER'] | |||
There was a problem hiding this comment.
note it's has been discovered another situation, when ID_NET_DRIVER is not defined and it'S not related to PCI/non-PCI issue. For more info, see RHEL-29551
Non-PCI network devices (present usually on IBM Z architecture) does not have ID_VENDOR_ID attribute and also there is nothing we could put into Interface.pci_info about them.
For such devices, set empty string for Interface.vendor field and None value for pci_info.
The Interface model has been updated, allowing None value for pci_info field.
jira: RHEL-22371